mkbd65/vial-qmk
Watch
1
0
Fork
You've already forked vial-qmk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tap dance: fix behavior when interrupted and hold is defined but not tap

Browse source 
fall into hold on interrupt if corresponding tap action isn't defined
for the case of double-tap vs tap-then-hold, continue to prefer the
double-tap interrupt following the existing permissive=false model
This commit is contained in:
Ilya Zhuravlev 2023-02-13 09:47:07 -06:00
commit 76215abd38
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
quantum/vial.c
View file

@ -376,6 +376,8 @@ static void on_dance_finished(qk_tap_dance_state_t *state, void *user_data) {
case SINGLE_TAP: { case SINGLE_TAP: {
if (td_entry.on_tap) if (td_entry.on_tap)
vial_keycode_down(td_entry.on_tap); vial_keycode_down(td_entry.on_tap);
else if (td_entry.on_hold)
vial_keycode_down(td_entry.on_hold);
break; break;
} }
case SINGLE_HOLD: { case SINGLE_HOLD: {
@ -414,6 +416,10 @@ static void on_dance_finished(qk_tap_dance_state_t *state, void *user_data) {
if (td_entry.on_tap) { if (td_entry.on_tap) {
vial_keycode_tap(td_entry.on_tap); vial_keycode_tap(td_entry.on_tap);
vial_keycode_down(td_entry.on_tap); vial_keycode_down(td_entry.on_tap);
} else if (td_entry.on_double_tap) {
vial_keycode_down(td_entry.on_double_tap);
} else if (td_entry.on_tap_hold) {
vial_keycode_down(td_entry.on_tap_hold);
} }
break; break;
} }
@ -432,6 +438,8 @@ static void on_dance_reset(qk_tap_dance_state_t *state, void *user_data) {
case SINGLE_TAP: { case SINGLE_TAP: {
if (td_entry.on_tap) if (td_entry.on_tap)
vial_keycode_up(td_entry.on_tap); vial_keycode_up(td_entry.on_tap);
else if (td_entry.on_hold)
vial_keycode_up(td_entry.on_hold);
break; break;
} }
case SINGLE_HOLD: { case SINGLE_HOLD: {
@ -467,6 +475,10 @@ static void on_dance_reset(qk_tap_dance_state_t *state, void *user_data) {
case DOUBLE_SINGLE_TAP: { case DOUBLE_SINGLE_TAP: {
if (td_entry.on_tap) { if (td_entry.on_tap) {
vial_keycode_up(td_entry.on_tap); vial_keycode_up(td_entry.on_tap);
} else if (td_entry.on_double_tap) {
vial_keycode_up(td_entry.on_double_tap);
} else if (td_entry.on_tap_hold) {
vial_keycode_up(td_entry.on_tap_hold);
} }
break; break;
} }