mkbd65/vial-qmk
Watch
1
0
Fork
You've already forked vial-qmk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Compare commits

merge into: mkbd65:vial
Branches Tags
mkbd65:vial
mkbd65:merge-2025-06-21
mkbd65:tap-dance-tap-hold-fix
mkbd65:old-sekigon-gonnoc-rp2040
...
pull from: mkbd65:tap-dance-tap-hold-fix
Branches Tags
mkbd65:vial
mkbd65:merge-2025-06-21
mkbd65:tap-dance-tap-hold-fix
mkbd65:old-sekigon-gonnoc-rp2040
Sign in to create a new pull request.
Author SHA1 Message Date
Ilya Zhuravlev
76215abd38 tap dance: fix behavior when interrupted and hold is defined but not tap 
fall into hold on interrupt if corresponding tap action isn't defined
for the case of double-tap vs tap-then-hold, continue to prefer the
double-tap interrupt following the existing permissive=false model
 2023-02-13 09:47:07 -06:00
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
quantum/vial.c
View file

@ -376,6 +376,8 @@ static void on_dance_finished(qk_tap_dance_state_t *state, void *user_data) {
case SINGLE_TAP: {
if (td_entry.on_tap)
vial_keycode_down(td_entry.on_tap);
else if (td_entry.on_hold)
vial_keycode_down(td_entry.on_hold);
break;
}
case SINGLE_HOLD: {
@ -414,6 +416,10 @@ static void on_dance_finished(qk_tap_dance_state_t *state, void *user_data) {
if (td_entry.on_tap) {
vial_keycode_tap(td_entry.on_tap);
vial_keycode_down(td_entry.on_tap);
} else if (td_entry.on_double_tap) {
vial_keycode_down(td_entry.on_double_tap);
} else if (td_entry.on_tap_hold) {
vial_keycode_down(td_entry.on_tap_hold);
}
break;
}
@ -432,6 +438,8 @@ static void on_dance_reset(qk_tap_dance_state_t *state, void *user_data) {
case SINGLE_TAP: {
if (td_entry.on_tap)
vial_keycode_up(td_entry.on_tap);
else if (td_entry.on_hold)
vial_keycode_up(td_entry.on_hold);
break;
}
case SINGLE_HOLD: {
@ -467,6 +475,10 @@ static void on_dance_reset(qk_tap_dance_state_t *state, void *user_data) {
case DOUBLE_SINGLE_TAP: {
if (td_entry.on_tap) {
vial_keycode_up(td_entry.on_tap);
} else if (td_entry.on_double_tap) {
vial_keycode_up(td_entry.on_double_tap);
} else if (td_entry.on_tap_hold) {
vial_keycode_up(td_entry.on_tap_hold);
}
break;
}